Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update compareoptions default values #22230

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

agaudreault
Copy link
Member

@agaudreault agaudreault commented Mar 6, 2025

Description

  • Ignore all resource status from diff instead of just CRD
  • Automatically add the user defined differences to ignored resource updates

Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault agaudreault requested review from a team as code owners March 6, 2025 16:37
Copy link

bunnyshell bot commented Mar 6, 2025

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-trwolo.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-trwolo.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault agaudreault enabled auto-merge (squash) March 7, 2025 20:04
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.84%. Comparing base (14a09be) to head (5326341).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
util/settings/settings.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22230      +/-   ##
==========================================
+ Coverage   55.82%   55.84%   +0.01%     
==========================================
  Files         342      342              
  Lines       57213    57215       +2     
==========================================
+ Hits        31940    31951      +11     
+ Misses      22639    22628      -11     
- Partials     2634     2636       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant