Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable errorf of perfsprint linter #21280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

Description

enables and fixes errorf rule of perfsprint linter issues.

Copy link

bunnyshell bot commented Dec 20, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@mmorel-35 mmorel-35 force-pushed the perfsprint/errorf branch 2 times, most recently from 55a0a8f to 8040a2e Compare December 20, 2024 20:52
@mmorel-35 mmorel-35 marked this pull request as ready for review December 20, 2024 21:22
@mmorel-35 mmorel-35 requested a review from a team as a code owner December 20, 2024 21:22
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 27.11864% with 129 lines in your changes missing coverage. Please review.

Project coverage is 55.24%. Comparing base (12a4dab) to head (d899639).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/app.go 0.00% 21 Missing ⚠️
server/application/application.go 9.09% 10 Missing ⚠️
cmd/argocd/commands/repo.go 0.00% 8 Missing ⚠️
util/manifeststream/stream.go 0.00% 6 Missing ⚠️
cmd/argocd/commands/repocreds.go 0.00% 5 Missing ⚠️
server/extension/extension.go 50.00% 5 Missing ⚠️
cmd/argocd/commands/admin/repo.go 0.00% 4 Missing ⚠️
util/gpg/gpg.go 0.00% 4 Missing ⚠️
...cationset/services/scm_provider/bitbucket_cloud.go 0.00% 3 Missing ⚠️
cmd/argocd/commands/cert.go 0.00% 3 Missing ⚠️
... and 40 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21280      +/-   ##
==========================================
+ Coverage   53.34%   55.24%   +1.89%     
==========================================
  Files         337      337              
  Lines       57056    57055       -1     
==========================================
+ Hits        30439    31522    +1083     
+ Misses      23974    22843    -1131     
- Partials     2643     2690      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mmorel-35 mmorel-35 force-pushed the perfsprint/errorf branch 2 times, most recently from 72b69d8 to 7718058 Compare December 21, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants