Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable importas for k8s.io/apimachinery/pkg/api/errors #21262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Dec 19, 2024

Description

Importas helps ensure consistency of imports aliases.

This is only for k8s.io/apimachinery/pkg/api/errors yet here

@mmorel-35 mmorel-35 requested a review from a team as a code owner December 19, 2024 17:29
Copy link

bunnyshell bot commented Dec 19, 2024

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@mmorel-35 mmorel-35 force-pushed the importas branch 4 times, most recently from f6c79ac to f8c4c76 Compare December 19, 2024 18:00
@mmorel-35 mmorel-35 marked this pull request as draft December 19, 2024 18:25
@mmorel-35 mmorel-35 marked this pull request as ready for review December 19, 2024 18:50
@mmorel-35 mmorel-35 marked this pull request as draft December 19, 2024 19:40
@mmorel-35 mmorel-35 changed the title chore: enable importas chore: enable importas for k8s.io/apimachinery/pkg/api/errors Dec 19, 2024
@mmorel-35 mmorel-35 marked this pull request as ready for review December 19, 2024 23:15
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 34.17722% with 52 lines in your changes missing coverage. Please review.

Project coverage is 55.21%. Comparing base (12a4dab) to head (5bddfbb).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
util/grpc/errors.go 38.46% 8 Missing ⚠️
cmd/argocd/commands/admin/backup.go 0.00% 7 Missing ⚠️
server/application/application.go 30.00% 6 Missing and 1 partial ⚠️
util/clusterauth/clusterauth.go 16.66% 1 Missing and 4 partials ⚠️
server/applicationset/applicationset.go 0.00% 3 Missing ⚠️
server/notification/notification.go 0.00% 3 Missing ⚠️
...cationset/controllers/applicationset_controller.go 33.33% 0 Missing and 2 partials ⚠️
controller/appcontroller.go 60.00% 1 Missing and 1 partial ⚠️
controller/sharding/sharding.go 0.00% 0 Missing and 2 partials ⚠️
server/project/project.go 0.00% 2 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21262      +/-   ##
==========================================
+ Coverage   53.34%   55.21%   +1.86%     
==========================================
  Files         337      337              
  Lines       57056    57055       -1     
==========================================
+ Hits        30439    31505    +1066     
+ Misses      23974    22857    -1117     
- Partials     2643     2693      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 force-pushed the importas branch 3 times, most recently from 20c26a5 to 3168434 Compare December 21, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant