fix: add support for overwriting the UI extensions path

[vasilegroza]

via the environment variable ARGOCD_EXTENSIONS_SHARED_PATH

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

• 🔵 /bns:start to start the environment
• 🚀 /bns:deploy to redeploy the environment
• ❌ /bns:delete to remove the environment

[vasilegroza]

Reason for this change:

• ArgoCD is installed in a closed medium, where we cannot install the UI extensions in the /tmp/extensions
• In this case, the UI extensions will be installed at the child docker image build time, into a custom directory.
• Then, the custom directory can be passed to the ArgoCD via the ARGOCD_EXTENSIONS_SHARED_PATH environment variable.
• This will also ensure the immutability of the docker-image/k8s-pod.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@544aea1). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
cmd/argocd-server/commands/argocd_server.go	0.00%	5 Missing ⚠️
server/server.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #21027   +/-   ##
=========================================
  Coverage          ?   53.46%           
=========================================
  Files             ?      339           
  Lines             ?    57185           
  Branches          ?        0           
=========================================
  Hits              ?    30575           
  Misses            ?    23982           
  Partials          ?     2628           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andrii-korotkov-verkada]

Let's add it along the other params here

argo-cd/cmd/argocd-server/commands/argocd_server.go

Line 289 in 52dbe51

command.Flags().BoolVar(&insecure, "insecure", env.ParseBoolFromEnv("ARGOCD_SERVER_INSECURE", false), "Run server without TLS")

[ishitasequeira]

@vasilegroza , can you also add the new variable to argocd-server-deployment.yaml similar to

argo-cd/manifests/base/server/argocd-server-deployment.yaml

Lines 265 to 270 in 2f51067

	- name: ARGOCD_SERVER_WEBHOOK_PARALLELISM_LIMIT
	valueFrom:
	configMapKeyRef:
	name: argocd-cmd-params-cm
	key: server.webhook.parallelism.limit
	optional: true

[vasilegroza]

@vasilegroza , can you also add the new variable to argocd-server-deployment.yaml similar to

argo-cd/manifests/base/server/argocd-server-deployment.yaml

Lines 265 to 270 in 2f51067

	- name: ARGOCD_SERVER_WEBHOOK_PARALLELISM_LIMIT
	valueFrom:
	configMapKeyRef:
	name: argocd-cmd-params-cm
	key: server.webhook.parallelism.limit
	optional: true

patched.

[vasilegroza]

@vasilegroza , can you also add the new variable to argocd-server-deployment.yaml similar to

argo-cd/manifests/base/server/argocd-server-deployment.yaml

Lines 265 to 270 in 2f51067

	- name: ARGOCD_SERVER_WEBHOOK_PARALLELISM_LIMIT
	valueFrom:
	configMapKeyRef:
	name: argocd-cmd-params-cm
	key: server.webhook.parallelism.limit
	optional: true

@ishitasequeira can you review it one more time?