Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add applicationset git values #386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add applicationset git values #386

wants to merge 1 commit into from
+49 −3

Conversation

drdkmkkr
Copy link

@drdkmkkr drdkmkkr commented Apr 9, 2024 •
edited

Changes

  • add missing values field to to application_set git generators
    • mostly based on the same implementation as used for cluster generators
  • add missing go_template_options field to application_set spec

@drdkmkkr drdkmkkr marked this pull request as draft April 9, 2024 14:23
@drdkmkkr
feat: add applicationset git values
7583d2b 
Signed-off-by: Mikkel Kristensen <[email protected]>

clean up

clean up

run make generate
@drdkmkkr drdkmkkr force-pushed the feat/add-applicationset-git-values branch from 0e17980 to 7583d2b Compare April 9, 2024 14:52
@drdkmkkr drdkmkkr marked this pull request as ready for review April 9, 2024 15:07
@github-actions GitHub Actions
Copy link

This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Apr 24, 2024
@onematchfox
Copy link
Collaborator

not stale

@github-actions github-actions bot removed the Stale label Apr 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label May 9, 2024
@onematchfox
Copy link
Collaborator

not stale

@github-actions github-actions bot removed the Stale label May 10, 2024
@github-actions GitHub Actions
Copy link

This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label May 24, 2024
@onematchfox
Copy link
Collaborator

not stale - sorry for the delay in looking at this

@github-actions github-actions bot removed the Stale label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drdkmkkr @onematchfox