Skip to content

fix(gitlab,api): optimize commit status updates and improve error handling#1187

Open
rackam77 wants to merge 1 commit intoargoproj-labs:mainfrom
rackam77:fix-gitlab-commit-status
Open

fix(gitlab,api): optimize commit status updates and improve error handling#1187
rackam77 wants to merge 1 commit intoargoproj-labs:mainfrom
rackam77:fix-gitlab-commit-status

Conversation

@rackam77
Copy link

@rackam77 rackam77 commented Mar 12, 2026

Optimizes GitLab commit status updates by:

  • Skipping redundant API calls when status is already correctly set
  • Handling :enqueue state transition errors gracefully

@rackam77 rackam77 force-pushed the fix-gitlab-commit-status branch from 57d54a7 to 168b40f Compare March 12, 2026 17:20
@codecov-commenter
Copy link

Bundle Report

Bundle size has no change ✅

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.58%. Comparing base (ff88239) to head (e88502b).

Files with missing lines Patch % Lines
internal/scms/gitlab/commit_status.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1187      +/-   ##
==========================================
- Coverage   54.03%   53.58%   -0.46%     
==========================================
  Files          55       55              
  Lines        6344     6349       +5     
==========================================
- Hits         3428     3402      -26     
- Misses       2546     2566      +20     
- Partials      370      381      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rackam77 rackam77 force-pushed the fix-gitlab-commit-status branch from 168b40f to 9aacf90 Compare March 12, 2026 17:44
- Skip redundant GitLab API calls when status is already correctly set
- Handle :enqueue state transition errors gracefully
@rackam77 rackam77 force-pushed the fix-gitlab-commit-status branch from 9aacf90 to e88502b Compare March 13, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants