fix: use ssa for status to avoid conflicts#1184
Draft
zachaller wants to merge 6 commits intoargoproj-labs:mainfrom
Draft
fix: use ssa for status to avoid conflicts#1184zachaller wants to merge 6 commits intoargoproj-labs:mainfrom
zachaller wants to merge 6 commits intoargoproj-labs:mainfrom
Conversation
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Bundle ReportBundle size has no change ✅ |
crenshaw-dev
requested changes
Mar 11, 2026
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1184 +/- ##
==========================================
+ Coverage 54.03% 54.42% +0.38%
==========================================
Files 55 56 +1
Lines 6344 8491 +2147
==========================================
+ Hits 3428 4621 +1193
- Misses 2546 3484 +938
- Partials 370 386 +16 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
requested changes
Mar 11, 2026
Comment on lines
84
to
87
| // +required | ||
| // +kubebuilder:validation:MaxLength=64 | ||
| // +kubebuilder:validation:Pattern=`^([a-f0-9]{40}|[a-f0-9]{64})$` | ||
| // +kubebuilder:validation:Pattern=`^([a-f0-9]{40}|[a-f0-9]{64})?$` | ||
| Sha string `json:"sha"` |
Contributor
There was a problem hiding this comment.
Switch to optional and add omitempty?
Comment on lines
141
to
145
| // +required | ||
| // +kubebuilder:validation:MinLength=40 | ||
| // +kubebuilder:validation:MinLength=0 | ||
| // +kubebuilder:validation:MaxLength=64 | ||
| // +kubebuilder:validation:Pattern=`^([a-f0-9]{40}|[a-f0-9]{64})$` | ||
| // +kubebuilder:validation:Pattern=`^([a-f0-9]{40}|[a-f0-9]{64})?$` | ||
| ProposedHydratedSha string `json:"proposedHydratedSha"` |
Contributor
There was a problem hiding this comment.
Make it optional and remove the redundant MinLength=0 annotation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.