fix(templating): this syntax will fail the task to get crds informati…#1179
Draft
emirot wants to merge 2 commits intoargoproj-labs:mainfrom
Draft
fix(templating): this syntax will fail the task to get crds informati…#1179emirot wants to merge 2 commits intoargoproj-labs:mainfrom
emirot wants to merge 2 commits intoargoproj-labs:mainfrom
Conversation
…on in helm chart Signed-off-by: emirot <emirot.nolan@gmail.com>
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1179 +/- ##
==========================================
+ Coverage 53.68% 53.79% +0.11%
==========================================
Files 55 55
Lines 6344 6344
==========================================
+ Hits 3406 3413 +7
+ Misses 2559 2554 -5
+ Partials 379 377 -2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on in helm chart
What
It will fail that task https://github.com/argoproj-labs/gitops-promoter-helm/blob/main/hack/update-artifacthub-crd-annotations.sh
Test