Skip to content

feat: Allow CS label to prevent SCM reconciliation#1167

Open
Angivare wants to merge 1 commit intoargoproj-labs:mainfrom
Angivare:reflected-commit-statuses
Open

feat: Allow CS label to prevent SCM reconciliation#1167
Angivare wants to merge 1 commit intoargoproj-labs:mainfrom
Angivare:reflected-commit-statuses

Conversation

@Angivare
Copy link

@Angivare Angivare commented Mar 8, 2026

Support a label that prevents CommitStatus to be pushed back into SCM

First step for #1165 proposal

@Angivare Angivare force-pushed the reflected-commit-statuses branch from 9766bb6 to 2c3cef3 Compare March 8, 2026 23:35
@codecov-commenter
Copy link

Bundle Report

Bundle size has no change ✅

@Angivare Angivare force-pushed the reflected-commit-statuses branch 2 times, most recently from 3fdc9bf to b8a2c7c Compare March 8, 2026 23:58
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.72%. Comparing base (b939f94) to head (5c355d9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1167      +/-   ##
==========================================
+ Coverage   53.48%   53.72%   +0.24%     
==========================================
  Files          54       54              
  Lines        6168     6170       +2     
==========================================
+ Hits         3299     3315      +16     
+ Misses       2510     2504       -6     
+ Partials      359      351       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: angivare <angivare@pm.me>
@Angivare Angivare force-pushed the reflected-commit-statuses branch from b8a2c7c to 5c355d9 Compare March 9, 2026 00:21
@crenshaw-dev
Copy link
Contributor

Maybe this should just be a spec field instead of a label. @zachaller?

@crenshaw-dev crenshaw-dev changed the title Allow CS label to prevent SCM reconciliation feat: Allow CS label to prevent SCM reconciliation Mar 9, 2026
@zachaller
Copy link
Contributor

@crenshaw-dev maybe, I see you already commented on the authors original issue and reason for this PR. As for this PR it is an interesting idea we have talked about a TriggerEventing kind although it would probably be quite similar to the WebRequestCommitStatus just without the creation of the CommitStatus, I am not sure adding a skip field for the CS today without a real use case makes sense. If we do decide to say let the webrequestcommitstatus manager to disable commitstatus creation it might make sense to still create the CommitStatus kind but disable the Scm call instead which case this PR would be nice but agree I would probably do it as a spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants