feat: Allow CS label to prevent SCM reconciliation#1167
feat: Allow CS label to prevent SCM reconciliation#1167Angivare wants to merge 1 commit intoargoproj-labs:mainfrom
Conversation
9766bb6 to
2c3cef3
Compare
Bundle ReportBundle size has no change ✅ |
3fdc9bf to
b8a2c7c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1167 +/- ##
==========================================
+ Coverage 53.48% 53.72% +0.24%
==========================================
Files 54 54
Lines 6168 6170 +2
==========================================
+ Hits 3299 3315 +16
+ Misses 2510 2504 -6
+ Partials 359 351 -8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: angivare <angivare@pm.me>
b8a2c7c to
5c355d9
Compare
|
Maybe this should just be a spec field instead of a label. @zachaller? |
|
@crenshaw-dev maybe, I see you already commented on the authors original issue and reason for this PR. As for this PR it is an interesting idea we have talked about a TriggerEventing kind although it would probably be quite similar to the WebRequestCommitStatus just without the creation of the CommitStatus, I am not sure adding a skip field for the CS today without a real use case makes sense. If we do decide to say let the webrequestcommitstatus manager to disable commitstatus creation it might make sense to still create the CommitStatus kind but disable the Scm call instead which case this PR would be nice but agree I would probably do it as a spec. |
Support a label that prevents CommitStatus to be pushed back into SCM
First step for #1165 proposal