Add support for values write back in combination with Argocd-Vault-Plugin #637
+96
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argocd-image-updater doesn't support the use of plugins. This is problematic when integrations like argocd-vault-plugins are used for secrets management solutions.
This PR enables the use of ArgoCD-Vault-Plugin in combination with Helm Charts, by explicitly checking if two conditions are met:
Plugin
andIf both are true, this PR assumes a plugin is used which can process Helm charts. And as helm charts like to use
values.yaml
files (even when targetting more than 1 destination-clusters) this PR makes sure that changes are written back to a singlevalues.yaml
file. The downside of this approach is that when multiple destinations-clusters are present (so multiple Argo-Applications) there may be write-errors to git for the applications which are processed later. This is not an issue perse, as these applications will use the same (shared) values-file for deployment. If this is considered non-desired behaviour nonetheless, this can be changed into writing to application-specific values-files (like default for non-plugin write-back).