Use remote models for test #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2they
reviewed
Apr 15, 2025
| switch variant { | ||
| case .largev3: | ||
| modelPath = try largev3ModelPath() | ||
| modelName = "large-v3" |
There was a problem hiding this comment.
should we consider updating model here to v20240930 variant and compressed to download less?
There was a problem hiding this comment.
This code path isnt actively tested in the unit tests, and has been superseded but the regression test suite, so probably just a todo to remove it in the future
a2they
reviewed
Apr 15, 2025
| default: | ||
| modelPath = try tinyModelPath() | ||
| modelName = "tiny" | ||
| } | ||
| let computeOptions = ModelComputeOptions( |
There was a problem hiding this comment.
why cpu only? should this be only if target is simulator?
There was a problem hiding this comment.
Pretty old commit, may have been intended to keep the unit test output consistent across chips.
a2they
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the unit tests to be run from the example WhisperAX app without needing to run
make setupor download any models manually, which is useful for testing environments that use physical devices and require a host app.