Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n64: enable rumble support for homebrew #1285

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hackgrid
Copy link
Contributor

@hackgrid hackgrid commented Nov 13, 2023

Before this PR, mia always assigned the rumble pak + controller pak to homebrew ROMs without an known ID:

rpak = true;

Because the desktop-ui ALWAYS assigns controller pak to controller #1 and rumble paks ONLY to controller #2-3,
rumble never worked at all for these unknown homebrew games.

if(!transferPakConnected) {

This fixes this problem by not enabling controller pak for not known homebrew games.

I guess this should be fine, because I think most homebrew devs will use flash or sram for saving, instead of controller pak,
because the save space is very limited on controller pak for indivudal games and there is no advantage using it.

@rasky
Copy link
Collaborator

rasky commented Nov 13, 2023

I wouldn’t change the default based on reasoning, the backward compatibility is also a concern. The best solution would be to implement the full homebrew header that also defines requested controller configurations:
https://n64brew.dev/wiki/ROM_Header

I wouldn’t change defaults before there’s a way to override it

@hackgrid hackgrid marked this pull request as draft November 13, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants