Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: custom_berry_solidify does now handle double quotation marks too #22629

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Staars
Copy link
Contributor

@Staars Staars commented Dec 12, 2024

Description:

Solidifying custom Berry code did fail in the check for modules, when double quotation marks were used:

#@ solidify:fonts
var fonts = module("fonts") # would produce linker failure before, must have been module('fonts') before

Make regex more flexible for different quotation marks now.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241206
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit 6268066 into arendst:development Dec 12, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants