ADBDEV-7617: Fix query cancelation #173
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some circumstances, such as the unavailability of a remote server, we may be stuck for a long time in the finish_upload function. This happened because we are waiting for all connections to be closed. For this, we call the curl_multi_perform function. Since there is nothing to receive or send, it immediately exits, while informing us that we still have open connections. After that, we will stay in this loop until PXF reports an error on timeout. During this loop, we cannot cancel the request because there is no CHECK_FOR_INTERRUPTS call in the loop. This patch adds CHECK_FOR_INTERRUPTS to the connection completion waiting loop so that if we stay in this loop for a long time, the query can be canceled.
|
Allure report https://allure.dev.adsw.io/launch/105465 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some circumstances, such as the unavailability of a remote server, we may be
stuck for a long time in the finish_upload function. This happened because we
are waiting for all connections to be closed. For this, we call
the curl_multi_perform function. Since there is nothing to receive or send, it
immediately exits, while informing us that we still have open connections. After
that, we will stay in this loop until PXF reports an error on timeout. During
this loop, we cannot cancel the query because there is no CHECK_FOR_INTERRUPTS
call in the loop. This patch adds CHECK_FOR_INTERRUPTS to the connection
completion waiting loop so that if we stay in this loop for a long time, the
query can be canceled.