Add connectedTo for inline repeater and documentation about connectedTo #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofandel
force-pushed
the
fix/connected-fields
branch
from
00d048b
to
58bcfa2
Compare
Tofandel
force-pushed
the
fix/connected-fields
branch
from
58bcfa2
to
8346ae4
Compare
ifox
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the connectedTo method to InlineRepeater because it was missing and document the
connectedTomethod for the FormBuilderI'm still thinking connected fields would be better as another Form component because this is the only one not respecting the convention (all other components have their own class) and it creates disparity in the form builder, it also doesn't allow to encapsulate multiple fields at once or views because of this
I might PR the addition of the service with deprecation of the connectedTo later on