Don't fail if multiple core version are found #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facchinm
force-pushed
the
multiple_core_semver
branch
from
a8f5f26
to
cc60774
Compare
facchinm
force-pushed
the
multiple_core_semver
branch
from
1c51bee
to
315f22f
Compare
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
Also try to avoid failure by choosing one randomly (from a user POW this is perfectly acceptable since the erratic behaviour is due to a bug in Board Manager core). The warning reports the full path of the folder for easy copy/paste operations
cmaglie
force-pushed
the
multiple_core_semver
branch
from
315f22f
to
cad8dcb
Compare
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the latest one based on semver
a dependency was added (github.com/blang/semver), hopefully we'll use it somwhere else since it's really useful
In this way we get rid of the annoying
Platform {0} (package {1}) is unknown, changing it with a warning.The multiple cores is a pre 1.6.7 Board Manager bug so it should slowly fade away.
@matthijskooijman @cmaglie