Lwip wrapper memory issues #153
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provided a destructor that takes care of deallocating the _tcp_client only when allocated with mem_alloc() and not passed in the constructor
andreagilardoni
force-pushed
the
lwip-wrapper-memory-issues
branch
from
b1b6b27
to
e66f5cf
Compare
per1234
added
type: imperfection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lwip wrapper has memory issues that may cause memory leaks and dangling pointers. This PR is the beginning of the work to fix these issues.
There is an improper memory management in the lwipClient and lwipServer that needs to be taken care of.