-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added WiFiClient::setConnectTimeout #99
base: master
Are you sure you want to change the base?
Conversation
@@ -63,8 +63,7 @@ int WiFiClient::connect(IPAddress ip, uint16_t port) { | |||
|
|||
unsigned long start = millis(); | |||
|
|||
// wait 4 second for the connection to close |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed these comments as they seem to be completely unrelated. (Copy paste accident from earlier?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it may be used later on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the comment was completely wrong. It was waiting to connect, not for the connection to close, and it waited 10 seconds not 4...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
f60b385
to
ae2e607
Compare
Rebased for master. I didn't get any feedback so I'm asking if it can be merged now. |
Hello, |
I tried with a connexion IP:PORT without SSL. It work with with remote host up and, partially, when down.The call ServerDrv::startClient() seems to block for 8s, with remote host down. My code test :
The Ethernet library have the same method but called setConnectionTimeout(). It would be nice to keep the same API. I'm interested in this feature to make non blocking connexion. |
Hey are there any updates on this? |
Would be great to have this option in the library. Any reason why not merging it? @thekunalsaini ? |
I believe these changes will not actually work because the timeout value is not passed to the nina-fm. It still waits there for the default time. |
|
what happened to this beautiful addition |
it doesn't work |
Suggestion for connect timeout based on #73. No documentation yet, just looking for implementation feedback.