Skip to content

Conversation

@robgaston
Copy link
Member

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Issues Solved

re: #12181

Checklist

  • I targeted one of these branches:
    • dev/8.1.x (under development): features, bugfixes not covered below
    • dev/8.0.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/7.6.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Ticket Background

Further comments

@bferguso does this PR capture what you are after here at all, at least w/ respect to the Graph/GraphModel? (no attempt was made here to build this out to other graph entities such as Node, wanted to make sure this approach made any sense)

@robgaston robgaston requested a review from bferguso June 9, 2025 21:13
@robgaston robgaston self-assigned this Jun 9, 2025
@robgaston robgaston marked this pull request as draft June 10, 2025 17:41
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eager to hear Brett's feedback, took a quick glance and this looks cool! 🎁

graph.create_draft_graph()

# ensures entity returned matches database entity
return self.get(pk=graph_model.graphid)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably leave this method only exposed on the proxy model because there are methods still trapped there, so it doesn't work on the vanilla model:

>>> GraphModel.objects.create_graph()
AttributeError: 'GraphModel' object has no attribute 'publish'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants