Updates controlled lists with uris from concepts #311
+8,167
−8,147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The URI update looks good - I'm seeing an issue with ACL's subclassing of the packages command to load controlled lists in that it's not being invoked during package load |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When controlled lists were generated for rascolls, the controlled list migration tool did not migrate uris. That has been fixed in the interim. Generally one could just rerun the migration with the fix, however, list items in rascolls have been added and modified since the migration, so reexporting is not possible without losing those changes. To avoid that, the uris were updated in place using the following SQL written by @johnatawnclementawn and then re-exported to the package.