Arcade Treasury TVL #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandbochs
reviewed
Apr 29, 2024
projects/arcade-xyz/constants.js
Outdated
| // Treasury | ||
| const ARCADE_TREASURY = '0xac2b57b372E198F09d4bF5F445CA1228771C12c5'; | ||
| const ETH_ADDRESS = '0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE'; | ||
| const ARCD = '0xe020B01B6fbD83066aa2e8ee0CCD1eB8d9Cc70bF'; |
There was a problem hiding this comment.
consider renaming this var to ARCD_TOKEN
sandbochs
requested changes
Apr 29, 2024
There was a problem hiding this comment.
Shouldn't the treasury export go in a file called arcade-xyz.js here https://github.com/DefiLlama/DefiLlama-Adapters/tree/main/projects/treasury ?
sandbochs
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for getting the Arcade treasury TVL via the DefiLlama adapter module.
To test, run:
node test.js projects/treasury/arcade-xyz.jsThe returned TVL in the treasury should equal the number of ARCD tokens held by the treasury contract multiplied by the current ARCD price.