-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the feedback issue #1455
base: main
Are you sure you want to change the base?
Fixed the feedback issue #1455
Conversation
@Niharika0104 is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Niharika0104
There is an error, could you please resolve.
line 201
{"_id": ObjectId(data["conversation_id"]), f"queries.{data["question_index"]}": {"$exists": True}},
^^^^^^^^^^^^^^
SyntaxError: f-string: unmatched '['
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1455 +/- ##
==========================================
+ Coverage 36.02% 36.04% +0.02%
==========================================
Files 68 68
Lines 3270 3268 -2
==========================================
Hits 1178 1178
+ Misses 2092 2090 -2 ☔ View full report in Codecov by Sentry. |
@ManishMadan2882 can you check it now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Niharika0104
Thanks for the update, I have few points:
I thought that once the feedback is given it shouldn't be taken again.. that's how it's happening in the chatGPT as well |
I think that this would be better as some reactions are accidental. |
@ManishMadan2882 so how should we change this and we want to take feedback only once the issue desc says so... |
If the user clicks on the reaction which they have already submitted, it should get removed from the DB. |
so when I click submitted feedback, then that particular feedback should be deleted from the db and also we should show the like and unlike buttons too.. |
Yep @Niharika0104 |
@Niharika0104 are you active on this PR? |
Fixes - [BUG] Make sure users can only send feedback once on convo and make it persistent #1166