Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the feedback issue #1455

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Niharika0104
Copy link
Contributor

Copy link

vercel bot commented Nov 26, 2024

@Niharika0104 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Niharika0104
There is an error, could you please resolve.

line 201
    {"_id": ObjectId(data["conversation_id"]), f"queries.{data["question_index"]}": {"$exists": True}},
                                                                ^^^^^^^^^^^^^^
SyntaxError: f-string: unmatched '['

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.04%. Comparing base (e22669f) to head (9d4aee5).
Report is 86 commits behind head on main.

Files with missing lines Patch % Lines
application/api/user/routes.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1455      +/-   ##
==========================================
+ Coverage   36.02%   36.04%   +0.02%     
==========================================
  Files          68       68              
  Lines        3270     3268       -2     
==========================================
  Hits         1178     1178              
+ Misses       2092     2090       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Niharika0104
Copy link
Contributor Author

@ManishMadan2882 can you check it now?

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Niharika0104
Thanks for the update, I have few points:

  • The feedback once submitted, is not getting deleted. Like I liked once, but need to remove my reaction.
  • The feedback once submitted, removes the other option. Like if I liked once, the dislike button is not visible.
    image

@Niharika0104
Copy link
Contributor Author

@Niharika0104
Thanks for the update, I have few points:

  • The feedback once submitted, is not getting deleted. Like I liked once, but need to remove my reaction.
  • The feedback once submitted, removes the other option. Like if I liked once, the dislike button is not visible.
    image

I thought that once the feedback is given it shouldn't be taken again.. that's how it's happening in the chatGPT as well

@ManishMadan2882
Copy link
Collaborator

@Niharika0104 Thanks for the update, I have few points:

  • The feedback once submitted, is not getting deleted. Like I liked once, but need to remove my reaction.
  • The feedback once submitted, removes the other option. Like if I liked once, the dislike button is not visible.
    image

I think that this would be better as some reactions are accidental.

@Niharika0104
Copy link
Contributor Author

@ManishMadan2882 so how should we change this and we want to take feedback only once the issue desc says so...

@ManishMadan2882
Copy link
Collaborator

If the user clicks on the reaction which they have already submitted, it should get removed from the DB.

@Niharika0104
Copy link
Contributor Author

If the user clicks on the reaction which they have already submitted, it should get removed from the DB.

so when I click submitted feedback, then that particular feedback should be deleted from the db and also we should show the like and unlike buttons too..
correct me if I'm wrong..

@ManishMadan2882
Copy link
Collaborator

If the user clicks on the reaction which they have already submitted, it should get removed from the DB.

so when I click submitted feedback, then that particular feedback should be deleted from the db and also we should show the like and unlike buttons too.. correct me if I'm wrong..

Yep @Niharika0104

@ManishMadan2882
Copy link
Collaborator

@Niharika0104 are you active on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants