Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance workspace listing #1063

Open
wants to merge 17 commits into
base: feature/connexion-to-groups
Choose a base branch
from
Open

Improve performance workspace listing #1063

wants to merge 17 commits into from

Conversation

zak39
Copy link
Collaborator

@zak39 zak39 commented Oct 2, 2024 •
edited
Loading

OP#3156

zak39 added 16 commits October 2, 2024 17:49
feat(controller): Return Manager group users in findAll and create ge…
3496c4f 
…tUsers function

When fetching spaces with the findAll function, users from the Workspace Manager group are now included, along with the total number of users in each workspace.
Additionally, I created the getUsers function to retrieve users related to a specific workspace.
feat(controller): Initialize user count to 0
49282ab 
When creating a group, the usersCount is initialized to 0 for the new
group.
feat(backend): Add countUsersInGroup function to GroupBackend
fd8e412
feat(service): Initialize usersCount when returning a formatted group
c67e6ca
fix(service): Users were not defined as an admin when formatting them
1c6e15e
feat(vue): Create LoadingUsers component and use it in WorkspaceContent
be84e4e 
This new component is very useful to check when workspaces and users are loading.
feat(vue): Initialize the loadingUsersWaitting in the store
3fdb2b4
feat(mutations): Create new mutation functions
7c68477 
- UPDATE_USERS: Update users for reactivity
- SET_LOADING_USERS_WAITTING : Enable or disable the loading icon when
  waitting for users to load.
- SET_NO_USERS : Enable or disable if the workspace has no users.
- INCREMENT_GROUP_USER_COUNT and INCREMENT_GROUP_USER_COUNT : Increment / Decrement the user count for a
  group by one
- INCREMENT_GROUP_USER_COUNT / DECREMENT_SPACE_USER_COUNT : Increment / Decrement of one to user count for a
  space by one
- CHANGE_USER_ROLE : Change the user role for an user when toggling it.
feat(js): Create getUsers function
01900ec 
The getUsers function get users from a workspace.
feat(actions): Create action functions related to mutation funcitons
dabd693
feat(vue): Get users when loading the current page
ba66433
feat(vue): Define count as the counter for users in GroupMenuItem
31aae5b
feat(vue): Define the counter for each section in SpaceMenuItem
a09a6af
feat(vue): Trigger incrementing user counter depending on the case
ff02d98 
The different cases are :

1. Increment by one when adding a user to a group (from GroupDetails)
2. Increment by one when adding a user to a space (from SpaceDetails)
3. Increment by one when adding a user to a subgroup (from GroupDetails)
4. Increment by one when adding a user to a WorkspaceManager group (from
   GroupDetails)
feat(vue): Trigger decrementing user counter depending on the case
4c9dea1
feat(getter): Define getter functions to retrieve user counters
29d1493
@zak39 zak39 added backend Modification related to backend frontend Modification related to frontend refactor labels Oct 2, 2024
@zak39 zak39 requested a review from smarinier October 2, 2024 16:33
@zak39 zak39 self-assigned this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarinier smarinier Awaiting requested review from smarinier

Assignees

@zak39 zak39

Labels
backend Modification related to backend frontend Modification related to frontend refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zak39