Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was poking around in this repo some, figured I'd submit this. The majority of this PR just adds arg
fixed = TRUE
wherever possible, which is an easy way to get a small speed boost from functionsstrsplit()
,grepl()
, andgsub()
.The only other edit is to add arg
stringsAsFactors = TRUE
to the call toas.data.frame()
in line 179 ofKWIC.R
(see here ). Without this arg, variableVar1
fromtable()
ends up as a factor, and when you subsetkwf
in line 180, that variable holds onto all of the levels that existed prior to subsetting, which makes the final data framekwf
a much larger object than it needs to be.Let me know if you want anything tweaked, I'm happy to make edits if need be.