[Feature] [Platform] ArangoPermissionToken #2027
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Custom Resource Definition (CRD) for ArangoPermissionToken, which appears to be part of a permission management feature for the ArangoDB Kubernetes Operator. The PR includes API definitions, generated client code, test utilities, and documentation updates. However, there are several critical issues that prevent this feature from working correctly.
Changes:
- New permission.arangodb.com/v1alpha1 API group with ArangoPermissionToken CRD
- Generated clientset, informers, and listers for the new API
- Test utility integration for CRUD operations
- Documentation for the new API and integration sidecar token support
Reviewed changes
Copilot reviewed 39 out of 126 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/apis/permission/v1alpha1/* | New API types and registration for ArangoPermissionToken (has critical bugs) |
| pkg/crd/crds/permission-token.yaml | CRD definition with incorrect metadata and storage configuration |
| pkg/generated/clientset/versioned/* | Generated Kubernetes client code for permission API |
| pkg/generated/informers/externalversions/permission/* | Generated informers for permission resources |
| pkg/generated/listers/permission/v1alpha1/* | Generated listers for permission resources |
| pkg/util/tests/kubernetes.go | Test utility updates for permission token CRUD operations |
| pkg/util/k8sutil/inspector/constants/* | Constants and GVK helpers (references wrong version) |
| docs/api/ArangoPermissionToken.V1Alpha1.md | API documentation for new CRD |
| docs/integration-sidecar.md | Documentation for optional ARANGO_TOKEN environment variable |
| Multiple copyright year updates | Updated from 2025 to 2026 across many files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pkg/util/k8sutil/inspector/constants/arango_permission_token_constants.go
Outdated
Show resolved
Hide resolved
ajanikow
force-pushed
the
feature/platform/permission_token
branch
from
14fa986 to
4a72520
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 99 out of 186 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 105 out of 192 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.