Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Add missing tests #921

Merged
merged 2 commits into from
May 23, 2023
Merged

[TEST] Add missing tests #921

merged 2 commits into from
May 23, 2023

Conversation

MatthieuJoulot
Copy link
Contributor

@MatthieuJoulot MatthieuJoulot commented May 17, 2023 •
edited
Loading

Adding some missing instantiation tests. I do not know if pydra-freesurferworks @ghisvail ?

NicolasGensollen
NicolasGensollen approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! Thanks for spotting these @MatthieuJoulot ! 👍

@ghisvail
Copy link
Contributor

I do not know if pydra-freesurferworks @ghisvail ?

It should. Which interfaces are you planning to use?

@NicolasGensollen NicolasGensollen merged commit a08d1c8 into aramis-lab:dev May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghisvail ghisvail ghisvail approved these changes

@NicolasGensollen NicolasGensollen NicolasGensollen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatthieuJoulot @ghisvail @NicolasGensollen