[PYDRA] Statistics Volume Correction #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @MatthieuJoulot !
I think this is looking good. I made a super quick first pass with a few comments.
Will take a closer look next week !
clinica/pipelines/statistics_volume_correction/statistics_volume_correction_utils.py
Outdated
Show resolved
Hide resolved
clinica/pipelines/statistics_volume_correction/statistics_volume_correction_utils.py
Outdated
Show resolved
Hide resolved
clinica/pipelines/statistics_volume_correction/statistics_volume_correction_utils.py
Outdated
Show resolved
Hide resolved
clinica/pipelines/statistics_volume_correction/statistics_volume_correction_utils.py
Outdated
Show resolved
Hide resolved
clinica/pipelines/statistics_volume_correction/statistics_volume_correction_utils.py
Outdated
Show resolved
Hide resolved
clinica/pipelines/statistics_volume_correction/statistics_volume_correction_utils.py
Outdated
Show resolved
Hide resolved
clinica/pipelines/statistics_volume_correction/statistics_volume_correction_utils.py
Outdated
Show resolved
Hide resolved
clinica/pipelines/statistics_volume_correction/statistics_volume_correction_utils.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Gensollen <[email protected]>
clinica/pydra/statistics_volume_correction/statistics_volume_correction_cli.py
Outdated
Show resolved
Hide resolved
MatthieuJoulot
force-pushed
the
pydra-stat-vol-cor
branch
from
e937a1d to
c37114e
Compare
There was a problem hiding this comment.
Thanks @MatthieuJoulot !
The code LGTM. I just need to test it locally and this should be good to merge !
clinica/pipelines/statistics_volume_correction/statistics_volume_correction_utils.py
Outdated
Show resolved
Hide resolved
clinica/pipelines/statistics_volume_correction/statistics_volume_correction_utils.py
Outdated
Show resolved
Hide resolved
clinica/pipelines/statistics_volume_correction/statistics_volume_correction_utils.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Gensollen <[email protected]>
NicolasGensollen
approved these changes
Apr 12, 2023
|
Merging when CI's happy... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pydra version of the statistics volume correction pipeline