chore: rename rule argument filters to data filters #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/ebpf
kind/documentation
area/UX
area/events
area/filtering
area/flags
labels
rscampos
commented
May 22, 2024
geyslan
approved these changes
May 23, 2024
rscampos
force-pushed
the
4031_rename_rule_arg_to_data
branch
from
300489c
to
865f1d6
Compare
|
@geyslan add some tests and accept the suggestions. Also rename some "argument" to "data" in the file data_test.go |
geyslan
reviewed
May 23, 2024
geyslan
reviewed
May 23, 2024
Created some tests for args option. The tests need to be deprecated after removing the args option.
Refactored the code in order to change the option args to name to be consistent with the new event structure. Option args is also supported but will be deprecated in future.
rscampos
force-pushed
the
4031_rename_rule_arg_to_data
branch
from
865f1d6
to
2c52874
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
fix: #4031
2c52874 chore: rename args to data field
2e98d6b chore(tests): rename args to data field and add tests
098dbb4 chore(yaml): rename args to data in the example
61244d8 chore(docs): rename args to data
2c52874 chore: rename args to data field
2e98d6b chore(tests): rename args to data field and add tests
2. Explain how to test it
3. Other comments