feat(events): introduce events fallbacks #3965
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO, if we're going by an approach where we can replace an entire set of dependency with another, then instead of having a recursive definition, each event should just have an array of definition so the map becomes |
Introduce the concept of events failure because of dependencies. Add events the ability to declare a fallback dependencies, to be used upon failure. This allows events to implement not necessarily supported implementation, for new kernels for example, with other implementation to cover unsupported scenarios.
AlonZivony
force-pushed
the
feature/fallback-dependencies-v2
branch
from
05ceb49
to
739c1e6
Compare
|
This PR is missing e2e tests. |
AlonZivony
force-pushed
the
feature/fallback-dependencies-v2
branch
from
739c1e6
to
f36a005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Introduce the concept of events failure because of dependencies.
Add events the ability to declare a fallback dependencies, to be used upon failure.
This allows events to implement not necessarily supported implementation,
for new kernels for example, with other implementation to cover unsupported scenarios.
2. Explain how to test it
3. Other comments