Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refactor/cloud scanning #510

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Conversation

danielsagi
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Also include relevant motivation and context. List any dependencies that are required for this change.

Contribution Guidelines

Please Read through the Contribution Guidelines.

Fixed Issues

Please mention any issues fixed in the PR by referencing it properly in the commit message.
As per the convention, use appropriate keywords such as fixes, closes, resolves to automatically refer the issue.
Please consult official github documentation for details.

Fixes #(issue)

"BEFORE" and "AFTER" output

To verify that the change works as desired, please include an output of terminal before and after the changes under headings "BEFORE" and "AFTER".

BEFORE

Any Terminal Output Before Changes.

AFTER

Any Terminal Output Before Changes.

Contribution checklist

  • I have read the Contributing Guidelines.
  • The commits refer to an active issue in the repository.
  • I have added automated testing to cover this case.

Notes

Please mention if you have not checked any of the above boxes.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #510 (3df7ea8) into main (a578726) will increase coverage by 1.31%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   65.26%   66.58%   +1.31%     
==========================================
  Files          44       46       +2     
  Lines        2456     2523      +67     
==========================================
+ Hits         1603     1680      +77     
+ Misses        853      843      -10     
Impacted Files Coverage Δ
kube_hunter/core/events/types.py 83.18% <ø> (+0.37%) ⬆️
kube_hunter/modules/hunting/aks.py 56.06% <37.50%> (+1.64%) ⬆️
kube_hunter/modules/discovery/cloud/aws.py 40.90% <40.90%> (ø)
kube_hunter/modules/discovery/hosts.py 72.89% <50.00%> (+18.88%) ⬆️
kube_hunter/modules/discovery/cloud/azure.py 90.14% <90.14%> (ø)
kube_hunter/conf/__init__.py 97.05% <100.00%> (ø)
kube_hunter/conf/parser.py 81.81% <100.00%> (ø)
kube_hunter/core/types/components.py 100.00% <100.00%> (ø)
kube_hunter/modules/discovery/__init__.py 100.00% <100.00%> (ø)
kube_hunter/core/events/event_handler.py 87.27% <0.00%> (+0.60%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a578726...3df7ea8. Read the comment docs.

@danielsagi danielsagi marked this pull request as draft May 28, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants