Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhanced styling of packages page #1620

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Conversation

shivam8112005
Copy link
Contributor

Title and Issue number

Title : Enhanced styling of packages page

Issue No. : #1610

Code Stack : html, css

Close #1610

Description

This PR introduces a comprehensive redesign of the packages page to improve the overall user experience and visual appeal. The new styling enhances readability and interaction, making it easier for users to navigate and understand package details.

Video/Screenshots (mandatory)

Screen.Recording.2024-11-03.192621.mp4

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24 Extended
  • I am contributing under Hacktoberfest'24

Copy link

github-actions bot commented Nov 3, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit ad365de
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/672781657a7a610008075823
😎 Deploy Preview https://deploy-preview-1620--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shivam8112005
Copy link
Contributor Author

@apu52 is it ok ?

@apu52 apu52 changed the title Enhanced styling of packages page feat: Enhanced styling of packages page Nov 3, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivam8112005 Although the UI of the packages pg can be better , still Good efforts , Thanks for your valuable contribution

@apu52 apu52 merged commit a04e7b5 into apu52:main Nov 3, 2024
5 of 6 checks passed
Copy link

github-actions bot commented Nov 3, 2024

🎉🎉 Thank you for your contribution! Your PR #1620 has been merged! 🎉🎉

@shivam8112005
Copy link
Contributor Author

shivam8112005 commented Nov 3, 2024

@shivam8112005 Although the UI of the packages pg can be better , still Good efforts , Thanks for your valuable contribution

@apu52 if you give me any suggestions and if you want then i will work on this again. cause i dont exactly know what to add in this page !

@apu52
Copy link
Owner

apu52 commented Nov 3, 2024

@shivam8112005 u can make a better ui by maybe adding some additional package cards , like some interesting professional type package cards as well ass some more detailed description about the tour packages as well as some maybe good UI

@shivam8112005
Copy link
Contributor Author

shivam8112005 commented Nov 3, 2024

@apu52 ohk got it just tell me which type of images should i add in package cards?
and i will open an issue for it

@apu52
Copy link
Owner

apu52 commented Nov 3, 2024

@apu52 ohk got it just tell me which type of images should i add in package cards? and i will open an issue for it

yess , open a new issue on it & add images according to the package like tour packages like some discount & all maybe signify it with different type of colors

@shivam8112005
Copy link
Contributor Author

@apu52 ohk i am opening new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Enhanced Styling for Packages Page
2 participants