Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: About US page is redirected to Home page #1607

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

Zubaida0113
Copy link
Contributor

Title and Issue number

Title : About US page is not redirecting

Issue No. : #1561

Code Stack : HTML

Close #1561

Description

Fix the redirection link from About Us page to the Home page and the Start journey buttons now redirected to Login page.

Video/Screenshots (mandatory)

Tourguide.-.Google.Chrome.2024-10-31.15-22-27.1.mp4

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24 Extended
  • I am contributing under Hacktoberfest'24

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 724ffa0
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6723559b9d80f10008585e26
😎 Deploy Preview https://deploy-preview-1607--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Zubaida0113 Zubaida0113 changed the title ABOUT to HOME redirected About US page is not redirecting Oct 31, 2024
@Zubaida0113 Zubaida0113 changed the title About US page is not redirecting Fix: About US page is not redirecting Oct 31, 2024
@Zubaida0113 Zubaida0113 changed the title Fix: About US page is not redirecting Fix: About US page is redirected to Home page Oct 31, 2024
@Zubaida0113 Zubaida0113 changed the title Fix: About US page is redirected to Home page fix: About US page is redirected to Home page Oct 31, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zubaida0113

image

after your changes the UI looks totally messy as maybe the img paths are not connected , please try to fix this

@Zubaida0113
Copy link
Contributor Author

Zubaida0113 commented Oct 31, 2024

@apu52 I have checked and updated my branch with the main branch, and the images are loaded properly. Can you list the steps by which you had the issue?

The image code is working fine.
image

There are other issues like the hamburger variable but it doesn't affect the images.
image

This is the video on my changes.

Tourguide.-.Google.Chrome.2024-10-31.20-22-41.mp4
index.mp4

@apu52
Copy link
Owner

apu52 commented Oct 31, 2024

https://deploy-preview-1607--taupe-cendol-f7e2bb.netlify.app

This is the deployed link of your PR , like this Deployment will reflect that how your commits will show in the main web site as the final product . & I have also checked the deployment after your comment its still remains the same , U can also check through this link

@Zubaida0113
Copy link
Contributor Author

image
This is showing from my side.
How about opening it in incognito mode, if it works then maybe there is cache issue in the browser.
OR
Should I delete this pull and push the branch again.
Let me know.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zubaida0113 okk now this link is working well , maybe there was some glitch ....

@apu52 apu52 merged commit f200bbc into apu52:main Oct 31, 2024
7 of 11 checks passed
Copy link

🎉🎉 Thank you for your contribution! Your PR #1607 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: About US page is not redirecting
2 participants