Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signIn method in WalletCore to throw the message property #502

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

0xmaayan
Copy link
Collaborator

signIn() throws the whole Error object, which is not consistent with the other methods and it creates confusion and a poor dev exp

@0xmaayan 0xmaayan requested review from GhostWalker562 and hardsetting and removed request for kaw2k, hardsetting and kent-white March 14, 2025 15:22
@0xmaayan 0xmaayan merged commit 6a5737a into main Mar 14, 2025
6 checks passed
@0xmaayan 0xmaayan deleted the fix_signIn_throw branch March 14, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants