[DRAFT] Multi chain adapter #500

0xmaayan · 2025-03-10T20:03:00Z

Introducing different packages to handle cross-chain functionalities, that can be used to build and support a cross-chain adapter in any dapp.
Each package can be used as a standalone component, and the dapp should decide what packages it needs following its business logic.

Live example https://aptos-labs.github.io/aptos-wallet-adapter/nextjs-example-testing/swap

wallet-adapter-aggregator:
A folder that contains multiple packages, each represents a Wallet. In addition, it holds a wallet-adapter-aggregator-core package that holds the abstract class that each wallet must implement.
I implemented a conversion layer for each cross-chain wallet, to represent it as the official Aptos wallet standard. There are some issues I have seen, and I am open for any suggestions.

The Aptos wallet standard defines input and output types, and expects each feature to follow it. That becomes a bit difficult when trying to convert each wallet function/feature.
Overall, for Solana and I believe other future chains we can handle the types, but when it comes to EVM it is more complex. For example, returning AccountInfo from the connect() or getAccount() methods, is almost impossible because 1) this class represents an Aptos account (and therefore a 32 byte account) and 2) there is no way to retrieve the connected account publicKey from the account address (unless you submitted a transaction)

I am open for any implementation suggestions.

cross-chain-core:
A package that holds a cross-chain logic. Currently only provides CCTP transfer logic with Wormhole as the provider. In the Future, we will support more providers (LayerZero, Cellar, etc) and add it to that package.
In addition, this package can expose some related APIs like getAccountUsdcBalance() (still debating whether this should live in this package, or be part of the wallet features).

The CrossChainCore class accepts different dapp properties

network: Network; // the network to use
disableTelemetry?: boolean;

And the startCCTPTransfer() method in the WormholeProvider class accepts

sourceChain: Chain;
wallet: AdapterWallet;
destinationAddress: AccountAddressInput;
mainSigner: Account;
sponsorAccount?: Account | Partial<Record<Network, string>>; // a generated account or gas station key

cross-chain-react
A React state provider that uses

The cross-chain-core package
The wallet aggregator package the dapp wants to support

Next steps:

Gas station support
Implement signInWithX
Aptos aggregator wallet
Solana priority fee user config // currently sets priority fee by default, it should come from the dapp config
RPC user config
Expose getUsdcBalance() API
DAA support (blocked by [WIP] adding common doman AA aptos-core#16006, already ready to go here [Draft] Implement domain abstracted account aptos-ts-sdk#648)

packages/cross-chain-core/src/providers/wormhole/signers/SolanaSigner.ts

BriungRi · 2025-03-10T20:46:47Z

You can simplify the nextjs example by having the button for Sepolia Solana or Sui open the connect wallet modal for those wallets

BriungRi · 2025-03-10T20:48:31Z

packages/cross-chain-core/src/CrossChainCore.ts

+
+export type AptosAccount = Account;
+
+export type Chain = "Solana" | "Ethereum" | "Sui" | "Aptos";


why not enum?

BriungRi · 2025-03-10T20:50:50Z

packages/cross-chain-core/src/CrossChainCore.ts

+export type UsdcBalance = {
+  amount: string;
+  decimal: number;
+  display: string;


Not sure I would implement display in this component. I think better to let the developer choose how they want to display. I think it just gets complicated because

Developer might want to only use period to dilineate decimals, while others may want to use comma

Developer might want to use some kind of significant figures logic

Just think it's not a good idea to put it in this package because it is hard to undo these decisions later

BriungRi · 2025-03-10T20:52:20Z

packages/cross-chain-core/src/providers/wormhole/config/mainnet/chains.ts

+
+import { ChainsConfig } from "../types";
+
+export const mainnetChains: ChainsConfig = {


any reference link to where these values come from? Would be nice to leave as comments

hardsetting · 2025-03-11T19:01:09Z

packages/wallet-adapter-aggregator/eip6963/src/index.ts

+    icon: `data:image/svg+xml;base64,${string}`;
+    rdns: string;
+  };
+  provider: any;


yea, this should be

interface EIP1193Provider { on: (event: string, callback: (...args: any[]) => void) => void; request: (request: { method: string; params?: Array<unknown>; }) => Promise<any>; }

hardsetting · 2025-03-11T19:10:06Z

packages/wallet-adapter-aggregator/core/src/index.ts

+export abstract class AdapterWallet<
+  GetAccountOutput = any,
+  GetConnectedNetworkOutput = any,
+  ConnectOutput = any,
+  SignMessageInput = any,
+  SignMessageOutput = any,
+  SignTransactionInput = any,
+  SignTransactionOutput = any,
+  OnAccountChangeInput = any,
+  OnNetworkChangeInput = any,
+  SendTransactionInput = any,
+  SendTransactionOutput = any,
+> extends EventEmitter<WalletEvents> {


What utility does this wrapper class provide?
Wouldn't it be easier to just map the source chain adapter features into Aptos features?

Standard function types and signature makes it hard to implement source wallet methods as aptos standard methods

hardsetting · 2025-03-11T19:14:18Z

packages/wallet-adapter-aggregator/eip6963/src/utils.ts

+const EIP6963_ADDITIONAL_FEATURES = (
+  eip6963Wallet: EIP6963ProviderInfo
+): Eip6963Features => {


Why do we need these?
The source wallet already supports eip6963 features, why are we re-defining them?

Standard function types and signature makes it hard to implement source wallet methods as aptos standard methods

hardsetting · 2025-03-11T19:17:34Z

packages/wallet-adapter-aggregator/eip6963/src/index.ts

+export type Eip6963AccountInfo = {
+  address: string;
+  publicKey: Uint8Array<ArrayBufferLike>;
+};
+
+export type Eip6963Features = {
+  "eip6963:connect": {
+    connect: () => Promise<UserResponse<Eip6963AccountInfo>>;
+    version: string;
+  };
+  "eip6963:account": {
+    account: () => Promise<Eip6963AccountInfo>;
+    version: string;
+  };
+  "eip6963:sendTransaction": {
+    sendTransaction: (
+      transaction: TransactionRequest,
+      provider: ethers.BrowserProvider
+    ) => Promise<UserResponse<string>>;
+    version: string;
+  };
+  "eip6963:onAccountChange": {
+    onAccountChange: (
+      callback: (newAccount: Eip6963AccountInfo) => void
+    ) => void;
+    version: string;
+  };
+  "eip6963:signMessage": {
+    signMessage: (message: string) => Promise<UserResponse<Uint8Array>>;
+    version: string;
+  };
+  "eip6963:network": {
+    network: () => Promise<number>;
+    version: string;
+  };
+  // "eip6963:getUsdcBalance": {
+  //   getUsdcBalance: () => Promise<UsdcBalance>;
+  //   version: string;
+  // };
+};


I'm a bit confused as to why we need these.
I thought that the goal was to create an abstracted Aptos Account from a source chain.
How are these features needed?

Global DAA is still in the exploration path, and it most needed and relevant to a specific dapp we are building which will use a dapp specific DAA implementation.

Still, dapps need a way to communicate with the source wallet default methods, so we need to support it

hardsetting · 2025-03-11T19:25:39Z

apps/nextjs-example/next.config.mjs

@@ -2,11 +2,11 @@ const isProd = process.env.NODE_ENV === "production";

 /** @type {import('next').NextConfig} */
 const nextConfig = {
-  output: "export",
+  output: "npx serve@latest out",


What is this for?

when starting nextjs build locally next start, it does not support export anymore

hardsetting · 2025-03-11T19:42:56Z

packages/cross-chain-react/src/WalletProvider.tsx

+          sourceChain,
+          wallet,
+          destinationAddress:
+            "0x38383091fdd9325e0b8ada990c474da8c7f5aa51580b65eb477885b6ce0a36b7",


is this intended to be hardcoded?

just for now, eventually the dapp provides the destination account - either DAA or any other Aptos account

hardsetting · 2025-03-11T20:31:23Z

packages/cross-chain-core/src/providers/wormhole/index.ts

+    );
+
+    const resolver = this._wormholeContext.resolver([
+      routes.CCTPRoute, // manual CCTP


wondering what are the other options?
Is there a documentation page for the SDK?

can the resolver be cached with the context?
or is it expected to be obtained for each transfer through context.resolver(...)?

wondering what are the other options?
For now, Wormhole supports only Manual CCTP for Aptos

can the resolver be cached with the context?
can be cached

hardsetting · 2025-03-11T20:33:10Z

packages/cross-chain-core/src/providers/wormhole/index.ts

+    ]);
+
+    const route = await resolver.findRoutes(req);
+    const cctpRoute = route[0];


assuming first route is always best?

hardsetting · 2025-03-11T23:56:06Z

Took a good look, great work!
I have some high-level ideas I'd love to chat about when you have time

The flow I was hoping to see was something similar to this (hopefully you have access):
https://excalidraw.com/#json=dtzELJ8ezex0lWN18D-F1,3dKp9B39GvEuf4tifqTOQw

packages/cross-chain/cross-chain-core/src/providers/wormhole/signers/SolanaSigner.ts

0xmaayan · 2025-03-13T19:24:31Z

You can simplify the nextjs example by having the button for Sepolia Solana or Sui open the connect wallet modal for those wallets

That brings up questions around multi chain wallets. For example, Nightly which is a wallet that supports all those chains.
I rather leave it to the dapp to decide how it wants to display the wallets in its own WalletSelector implementation

github-advanced-security bot found potential problems Mar 10, 2025

View reviewed changes

0xmaayan requested review from gregnazario and BriungRi March 10, 2025 20:05

BriungRi reviewed Mar 10, 2025

View reviewed changes

hardsetting reviewed Mar 11, 2025

View reviewed changes

0xmaayan force-pushed the multi_chain branch from 681f46f to ea59b63 Compare March 13, 2025 19:21

github-advanced-security bot found potential problems Mar 13, 2025

View reviewed changes

0xmaayan force-pushed the multi_chain branch from ea59b63 to 59649a6 Compare March 13, 2025 19:23

0xmaayan force-pushed the multi_chain branch from 59649a6 to 4ac8945 Compare March 13, 2025 19:28

0xmaayan and others added 5 commits March 13, 2025 15:30

introduce multi chain swap components

cc42a00

Fix CSS

01d5583

Change postcss to CommonJS

21bbbfe

only one wallet connection

db610e5

remove unneeded folders

33e61e5

0xmaayan force-pushed the multi_chain branch from 4ac8945 to c135d6b Compare March 13, 2025 19:58

Introduce cross chain adapter

c823561

0xmaayan force-pushed the multi_chain branch from c135d6b to c823561 Compare March 14, 2025 15:18

add signInWith support

62764a4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DRAFT] Multi chain adapter #500

[DRAFT] Multi chain adapter #500

0xmaayan commented Mar 10, 2025 •

edited

Loading

BriungRi commented Mar 10, 2025

BriungRi Mar 10, 2025

BriungRi Mar 10, 2025

BriungRi Mar 10, 2025

hardsetting Mar 11, 2025

0xmaayan Mar 12, 2025 •

edited

Loading

hardsetting Mar 11, 2025

0xmaayan Mar 12, 2025

hardsetting Mar 11, 2025

0xmaayan Mar 12, 2025

hardsetting Mar 11, 2025

0xmaayan Mar 12, 2025

hardsetting Mar 11, 2025

0xmaayan Mar 12, 2025

hardsetting Mar 11, 2025

0xmaayan Mar 12, 2025

hardsetting Mar 11, 2025

hardsetting Mar 11, 2025

0xmaayan Mar 12, 2025

0xmaayan Mar 12, 2025

hardsetting Mar 11, 2025

0xmaayan Mar 12, 2025

hardsetting commented Mar 11, 2025

0xmaayan commented Mar 13, 2025


		export type AptosAccount = Account;

		export type Chain = "Solana" \| "Ethereum" \| "Sui" \| "Aptos";


		import { ChainsConfig } from "../types";

		export const mainnetChains: ChainsConfig = {

[DRAFT] Multi chain adapter #500

Are you sure you want to change the base?

[DRAFT] Multi chain adapter #500

Conversation

0xmaayan commented Mar 10, 2025 • edited Loading

BriungRi commented Mar 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xmaayan Mar 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hardsetting commented Mar 11, 2025

0xmaayan commented Mar 13, 2025

0xmaayan commented Mar 10, 2025 •

edited

Loading

0xmaayan Mar 12, 2025 •

edited

Loading