Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Txn emitter changes for it to be used for bulk emitter script #13248

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

igor-aptos
Copy link
Contributor

@igor-aptos igor-aptos commented May 10, 2024

Description

Create generic bulk_create_accounts, that anyone can use, without having EmitterJobRequest params object.
(we use this later for creating worker accounts)

Type of Change

  • Refactoring

Which Components or Systems Does This Change Impact?

  • Other - transaction generator/emitter

How Has This Been Tested?

with end-to-end bulk submit script

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented May 10, 2024

⏱️ 17m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 5m 🟥
run-tests-main-branch 4m 🟩
rust-targeted-unit-tests 3m 🟥
rust-lints 3m 🟥
general-lints 2m 🟩
semgrep/ci 22s 🟩
check-dynamic-deps 19s 🟩
file_change_determinator 12s 🟩
file_change_determinator 10s 🟩
permission-check 4s 🟩
permission-check 3s 🟩
permission-check 2s 🟩
permission-check 2s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@igor-aptos
Copy link
Contributor Author

ping @sitalkedia , @bchocho for reviews here

@igor-aptos igor-aptos force-pushed the igor/emitter_changes_for_bulk_submit_script branch from be4ccc4 to 32aac12 Compare May 22, 2024 17:31
Copy link
Contributor

@sitalkedia sitalkedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants