Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect instrument_ownership config option for Ruby #132

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

unflxw
Copy link
Contributor

@unflxw unflxw commented Jan 10, 2025

See appsignal/appsignal-ruby#1364. [skip review]


Add instrument_ownership config option

Switch from Webrick to Puma

Last commit (#131) updated Sinatra to version 4.1.0, which expects
Puma to be installed as the underlying web server instead of Webrick.

@backlog-helper
Copy link

backlog-helper bot commented Jan 10, 2025

Hi @unflxw,

We've found some issues with your Pull Request.

  • This Pull Request is missing labels. Please add labels to help identify types of Pull Requests. - (More info)

New issue guide | Backlog management | Rules | Feedback

@unflxw unflxw force-pushed the ruby-instrument-ownership-config-option branch from ab0f545 to fc2a629 Compare January 10, 2025 07:42
Add expectations for the `instrument_ownership` configuration option.
Last commit (#131) updated Sinatra to version 4.1.0, which expects
Puma to be installed as the underlying web server instead of Webrick.
@unflxw unflxw force-pushed the ruby-instrument-ownership-config-option branch from fc2a629 to ce1be95 Compare January 10, 2025 09:22
Expect the Ruby integration's diagnose to emit this configuration
option set to `false`.
@unflxw unflxw merged commit bc36448 into main Jan 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant