Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandoned files work #432

Merged
merged 12 commits into from
Jan 27, 2025
Merged

Abandoned files work #432

merged 12 commits into from
Jan 27, 2025

Conversation

ilandikov
Copy link
Contributor

@ilandikov ilandikov commented Jan 27, 2025

Pairing with @isidore

Summary by Sourcery

New Features:

  • Added functionality to download the detect_and_remove_abandoned script.

Copy link

sourcery-ai bot commented Jan 27, 2025

Reviewer's Guide by Sourcery

This pull request introduces changes to the FailedFileLog class to download and execute scripts for approving all files and detecting and removing abandoned files. It also includes changes to the test suite to ensure the tests are run in the correct directory.

Class diagram for FailedFileLog changes

classDiagram
    class FailedFileLog {
        -downloadedScriptCheck: boolean
        +downloadScripts()
        -downloadFile(baseScript: string)
    }
    note for FailedFileLog "Added new method downloadFile
to handle script downloads"
Loading

File-Level Changes

Change Details Files
The FailedFileLog class now downloads and executes scripts for approving all files and detecting and removing abandoned files.
  • Added a downloadFile method to download scripts from GitHub.
  • Modified the constructor to download the approve_all and detect_and_remove_abandoned scripts.
  • The script file name is now parameterized.
lib/Logs/FailedFileLog.ts
The test suite now changes the current directory before running the tests.
  • The test suite now changes the current directory to the original directory after running the tests.
test/commandLineTests.mts
The approved files for the nested folder tests have been removed.
  • The approved files for the nested folder tests have been removed.
test-projects/mochajs-tests/test/nested_folder_tests.root_folder.approved.txt
test-projects/mochajs-tests/test/sub-folder-a/nested_folder_tests.sub_folder_a.approved.txt
test-projects/mochajs-tests/test/sub-folder-b/nested_folder_tests.sub_folder_b.approved.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@isidore isidore merged commit a51eb43 into approvals:master Jan 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants