[SILGen] Fix a bug where the wrong convention was being used for computing the type of a closure thunk #73299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
computing the type of a closure thunk The ObjC selector family convention was being used instead of the C function type convention. rdar://127090209
|
@swift-ci please test |
|
@swift-ci please test |
rjmccall
reviewed
Apr 29, 2024
lib/SIL/IR/SILFunctionType.cpp
Outdated
| @@ -4109,6 +4109,19 @@ static CanSILFunctionType getUncachedSILFunctionTypeForConstant( | |||
| } | |||
| } | |||
|
|
|||
| // The type of the native-to-foreign thunk for a swift closure. | |||
| if (shouldStoreClangType(TC.getDeclRefRepresentation(constant)) && | |||
| constant.isForeign && constant.hasClosureExpr()) { | |||
There was a problem hiding this comment.
Could you check the foreign + closure conditions first? They seem like they'll weed things out a lot more than the shouldStoreClangType condition, which I guess is just future-proofing against other kinds of foreign reference.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ObjC selector family convention was being used instead of the C function type convention.
rdar://127090209