Account for different module ABI name when reconstructing a type #73291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A type's mangled name will store the module's ABI name, not the module's regular name. When reconstructing a type from a mangled name, the demangler needs to take that into account. rdar://126953614 (cherry picked from commit 04034d5)
|
@swift-ci test |
adrian-prantl
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 04034d5)
Explanation: A type's mangled name will store the module's ABI name, not the module's regular name. When reconstructing a type from a mangled name, the demangler needs to take that into account, and look up the module by both it's ABI name and regular name, otherwise type reconstruction will fail for types defined outside of the current module.
Scope: Small.
Issue: rdar://126953614
Original PRs: #73264
Risk: Low, affects type reconstruction of modules that use the -module-abi-name flag.