[Observation] Optimize cancellation path to avoid excessive copies #73288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
phausler
force-pushed
the
pr/observation_cancel_optimization
branch
from
5200475
to
326f694
Compare
phausler
force-pushed
the
pr/observation_cancel_optimization
branch
from
326f694
to
a8334ea
Compare
|
@swift-ci please test |
glessard
approved these changes
Apr 28, 2024
phausler
added a commit
to phausler/swift
that referenced
this pull request
Apr 30, 2024
phausler
added a commit
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code could potentially mis-optimize and create copies of the set for the cancellation tokens. This mutates it in-place to avoid those copies.
Resolves: rdar://127018986