[6.0] CMake: add option to link Swift content from Darwin toolchain #73283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed in specific Apple internal configurations -- as a result of the limited applicability, this option is not exposed through `build-script` on purpose. Addresses rdar://127014753 (cherry picked from commit 5f545b4)
|
@swift-ci please test |
|
@swift-ci please build toolchain |
|
@swift-ci please test WebAssembly |
compnerd
approved these changes
Apr 26, 2024
|
This will need #73303 to be picked as well before merging. |
Additional testing showed that the path I initially choose does not work in all scenarios. Expands on apple#73255 Still addresses rdar://127014753 (cherry picked from commit 291065d)
|
@swift-ci please test |
|
@swift-ci please build toolchain |
|
@swift-ci please test WebAssembly |
|
@swift-ci please test Windows |
shahmishal
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: introduce a CMake option that allow Swift binaries to link against content in Darwin toolchains -- this is needed in some Apple internal configurations
Radar: rdar://127014753
Scope: CMake build logic that configure the build for Swift binaries on Darwin platforms
Risk: low -- this behaviour is opt in
Testing: CI testing -- in particular ensured we can build a toolchain
Reviewed By: @compnerd and @al45tair in #73255