Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DebugInfo] Improve documentation & Fix discovered bugs #73276

Merged
merged 5 commits into from Apr 29, 2024

Conversation

Snowy1803
Copy link
Member

@Snowy1803 Snowy1803 commented Apr 26, 2024

Adds more documentation about updating debug values, and debug value expressions.

Fixes a few bugs: undef debug values being removed, constant debug values not working, arithmetic without a deref not working.
Add support for salvaging integer literals.

This increases the number of debug variables in the standard library by 1.7%

The biggest improvements in the amount of lost variables are: constant propagation (-81%), sil combine (-50%), dead code elimination (-31%), copy propagation (-59%), common subexpression elimination (-24%)

@Snowy1803
Copy link
Member Author

@swift-ci please test

@Snowy1803
Copy link
Member Author

@swift-ci please test source compatibility

@Snowy1803 Snowy1803 force-pushed the doc-and-fixes branch 2 times, most recently from ea41bbb to 655de5c Compare April 26, 2024 19:19
@Snowy1803 Snowy1803 marked this pull request as ready for review April 26, 2024 21:25
@Snowy1803
Copy link
Member Author

@swift-ci please test

Copy link
Member

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent update to the documentation!
The optimizer and IRGen changes look good!
I have a few minor wording suggestions inline.

docs/HowToUpdateDebugInfo.md Outdated Show resolved Hide resolved
docs/HowToUpdateDebugInfo.md Outdated Show resolved Hide resolved
docs/HowToUpdateDebugInfo.md Outdated Show resolved Hide resolved
docs/HowToUpdateDebugInfo.md Outdated Show resolved Hide resolved
docs/HowToUpdateDebugInfo.md Outdated Show resolved Hide resolved
docs/HowToUpdateDebugInfo.md Outdated Show resolved Hide resolved
docs/HowToUpdateDebugInfo.md Outdated Show resolved Hide resolved
@Snowy1803
Copy link
Member Author

@swift-ci please test

@Snowy1803 Snowy1803 merged commit ce68d74 into apple:main Apr 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants