Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backtracing][Linux] Disable invoking process_vm_readv() for older Android APIs #67478

Merged
merged 1 commit into from Jul 24, 2023

Conversation

finagolfin
Copy link
Contributor

The Android community CI has been broken ever since this was merged in #66334 last month, because that CI builds against Android API 21:

/home/ubuntu/jenkins/workspace/oss-swift-RA-linux-ubuntu-16.04-android-arm64/swift/stdlib/public/runtime/CrashHandlerLinux.cpp:665:12: error: use of undeclared identifier 'process_vm_readv'
    return process_vm_readv(memserver_pid, &local, 1, &remote, 1, 0);
           ^
1 error generated.

Disable invoking this function before API 23, where it was added, which I confirmed gets the stdlib building with API 21 again.

@al45tair, please review.

@al45tair
Copy link
Contributor

@swift-ci Please smoke test

@finagolfin
Copy link
Contributor Author

@bnbarham, ready for merge.

@bnbarham bnbarham merged commit b962cab into apple:main Jul 24, 2023
3 checks passed
@finagolfin finagolfin deleted the droid-ci branch July 24, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants