Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backtracing][Linux] Add Linux crash handler to the runtime. #66407

Merged
merged 5 commits into from Jun 7, 2023

Conversation

al45tair
Copy link
Contributor

@al45tair al45tair commented Jun 7, 2023

This also adds a function to demangle a symbol, and a way for the backtracing code to report warning messages to the same place as the main runtime.

I'd like to rename the _swift_isThunkFunction() SPI also, but we can't do that until we've made the changes to the _Backtracing library, so we'll do that there instead.

rdar://110261430

This also adds a function to demangle a symbol, and a way for the
backtracing code to report warning messages to the same place as
the main runtime.

I'd like to rename the _swift_isThunkFunction() SPI also, but we
can't do that until we've made the changes to the _Backtracing
library, so we'll do that there instead.

rdar://110261430
This was added to a later PR, but not to this one, though we need
it here.

rdar://110261430
This should have been disabled until apple#66338.

rdar://110261430
Mike and Max made various helpful suggestions, so I've added and updated
various comments and amended the code to cope with partial reads and
writes.

rdar://110261430
Moved the comment for `_swift_backtrace_demangle` into the header file
instead of it being in the implementation.

rdar://110261430
@al45tair al45tair added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 labels Jun 7, 2023
@al45tair al45tair requested a review from a team as a code owner June 7, 2023 07:47
@al45tair
Copy link
Contributor Author

al45tair commented Jun 7, 2023

Explanation: Adds the Linux crash handler to libswiftCore.
Risk: Low. Only affects Linux, and this code is disabled until the later enabling PR.
Original PR: #66334
Reviewed by: @mikeash @MaxDesiatov
Resolves: rdar://110261430
Tests: The Linux unwinding tests exercise this code (but those are in the enabling PR as they won't work until this is enabled).

@al45tair
Copy link
Contributor Author

al45tair commented Jun 7, 2023

@swift-ci Please test

@al45tair al45tair merged commit 96d78b5 into apple:release/5.9 Jun 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants