Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] [Linux] (Cherry Pick) Merge pull request #64633 from gwynne/patch-2-5.9 #65030

Closed
wants to merge 1 commit into from
Closed

[5.8] [Linux] (Cherry Pick) Merge pull request #64633 from gwynne/patch-2-5.9 #65030

wants to merge 1 commit into from

Conversation

gwynne
Copy link
Contributor

@gwynne gwynne commented Apr 9, 2023

Add the remaining toolchain-distributed runtime libs to autolink-extract. Cherry pick of #64312 via #64633.

(Hoping to get this into 5.8.1 if one ends up getting made.)

Add the remaining toolchain-distributed runtime libs to autolink-extract
@gwynne gwynne requested a review from a team as a code owner April 9, 2023 00:33
@al45tair
Copy link
Contributor

@swift-ci please test

@etcwilde
Copy link
Member

apple/swift-integration-tests#78

@swift-ci build toolchain

@tomerd tomerd changed the title [Linux] (Cherry Pick) Merge pull request #64633 from gwynne/patch-2-5.9 [5.8] [Linux] (Cherry Pick) Merge pull request #64633 from gwynne/patch-2-5.9 Apr 24, 2023
@etcwilde
Copy link
Member

There is an issue with statically linking on 5.9 and main where the link order appears to be wrong. We should not merge this until we are confident that this is not the issue.

@al45tair
Copy link
Contributor

al45tair commented May 2, 2023

We've decided to close this for now; it is unlikely to make it into 5.8 as there are problems in this area in 5.9 and main after merging its counterparts (which we are investigating).

@al45tair al45tair closed this May 2, 2023
@tomerd
Copy link
Member

tomerd commented May 2, 2023

@gwynne this changes has broken static linking on 5.9 and main. should we close it or mark as draft so this does not get accidentally merged? once the issue is resolved we can reconsider pulling it in

@al45tair
Copy link
Contributor

al45tair commented May 2, 2023

:-) I'd closed it already; we can always cherry-pick it again once we work out what the problem is.

@al45tair
Copy link
Contributor

al45tair commented May 2, 2023

(Also, it might not be this change per se that is the cause of the breakage; this one probably just exposed it.)

@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
@MaxDesiatov
Copy link
Member

I'm reviving this for 5.8 in #66246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants