Skip to content

Add io_uring support to System #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 109 commits into from
Jul 12, 2025
Merged

Add io_uring support to System #208

merged 109 commits into from
Jul 12, 2025

Conversation

Catfish-Man
Copy link
Member

No description provided.

@Catfish-Man Catfish-Man self-assigned this Oct 29, 2024
Catfish-Man
Catfish-Man commented Oct 29, 2024
View reviewed changes
Catfish-Man
Catfish-Man commented Oct 31, 2024
View reviewed changes
toffaletti
toffaletti reviewed Jan 19, 2025
View reviewed changes
@Catfish-Man Catfish-Man marked this pull request as ready for review July 8, 2025 23:55
@Catfish-Man Catfish-Man changed the title Draft changes to the io_uring prototype Add io_uring support to System Jul 8, 2025
@Catfish-Man
Copy link
Member Author

How concerned should I be about "error: unknown attribute 'unsafe'"? That just seems like a too-old compiler?

@Lukasa
Copy link

Lukasa commented Jul 9, 2025

The code does still have to compile in the older versions, so you should be able to protect against this by using #if compiler guards.

jrflat
jrflat reviewed Jul 11, 2025
View reviewed changes
Copy link

@jrflat jrflat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few questions but I think it overall looks good! Small nit but maybe we could group the new source files in an IORing folder?

@Catfish-Man
Copy link
Member Author

@swift-ci please test

@Catfish-Man
Copy link
Member Author

@swift-ci please test

jrflat
jrflat approved these changes Jul 11, 2025
View reviewed changes
Copy link

@jrflat jrflat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work chasing down those issues! 🎉

@Catfish-Man Catfish-Man merged commit 7f9dba8 into main Jul 12, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toffaletti toffaletti toffaletti left review comments

@Lukasa Lukasa Lukasa left review comments

@hassila hassila hassila left review comments

@rauhul rauhul rauhul left review comments

@jrflat jrflat jrflat approved these changes

@glessard glessard Awaiting requested review from glessard glessard is a code owner

@lorentey lorentey Awaiting requested review from lorentey lorentey is a code owner

@milseman milseman Awaiting requested review from milseman milseman is a code owner

Assignees

@Catfish-Man Catfish-Man

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Catfish-Man @Lukasa @toffaletti @hassila @rauhul @jrflat @oxy