[cxx-interop] Propagate interop flag to the test entry point target #7428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated test entry point target imports the test discovery target, which built with C++ interoperability enabled if any of its dependencies enable C++ interoperability. This logic didn't propagate the C++ interop flag to the entry point target. This triggered build errors that couldn't be worked around easily. rdar://125498997
egorzhdan
requested review from
bnbarham,
MaxDesiatov and
tomerd
as code owners
MaxDesiatov
approved these changes
Mar 27, 2024
|
@swift-ci test |
egorzhdan
added a commit
that referenced
this pull request
Apr 3, 2024
**Explanation**: Projects that use C++ interop for some of the Swift targets were failing to build in test mode (`swift test`) because the generated test entry point target wasn't being compiled with C++ interop enabled. **Scope**: Flags that are being passed to the entry point test target. **Risk**: Low, this only affects projects that explicitly enable C++ interop in the package manifest on non-Darwin platforms only. **Testing**: Added a build plan test. **Issue**: rdar://125498997 **Reviewer**: @MaxDesiatov approved #7428. (cherry picked from commit f529dae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Projects that use C++ interop for some of the Swift targets were failing to build in test mode (
swift test) because the generated test entry point target wasn't being compiled with C++ interop enabled.Modifications:
The logic that propagates the C++ interop compiler flag (
-cxx-interoperability-mode) to the discovery target now also runs for the entry point target.rdar://125498997