Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a swift-corelibs-foundation specific workaround #7425

Merged

Conversation

xedin
Copy link
Member

@xedin xedin commented Mar 25, 2024

CoreFoundation depends on dispatch, this dependency is implicit
and dispatch itself is bundled with swift toolchains. Let's add
a package specific workaround for Linux/Android targets to add
toolchain resources directory to search paths of clang build targets.

This is also a prerequisite for #7423

@MaxDesiatov MaxDesiatov added linux build system Changes to interactions with build systems Android labels Mar 26, 2024
Copy link
Member

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits WRT to use of UserToolchain.default in these tests, but otherwise LGTM. Thanks!

@xedin
Copy link
Member Author

xedin commented Mar 26, 2024

@swift-ci please test

We need this information to set `-w` and other package specific options.
CoreFoundation depends on dispatch, this dependency is implicit
and dispatch itself is bundled with swift toolchains. Let's add
a package specific workaround for Linux/Android targets to add
toolchain resources directory to search paths of clang build targets.
@xedin xedin force-pushed the toolchain-include-path-for-corelibs-foundation branch from 286c9a3 to a85039c Compare March 26, 2024 21:07
@xedin
Copy link
Member Author

xedin commented Mar 26, 2024

@swift-ci please test

@xedin
Copy link
Member Author

xedin commented Mar 26, 2024

@swift-ci please test Windows platform

@xedin xedin merged commit 42e86f9 into apple:main Mar 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android build system Changes to interactions with build systems linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants