Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use arguments instead of argumentList in the macro template #7424

Merged
merged 1 commit into from Mar 26, 2024
Merged

Use arguments instead of argumentList in the macro template #7424

merged 1 commit into from Mar 26, 2024

Conversation

ahoppen
Copy link
Contributor

@ahoppen ahoppen commented Mar 25, 2024

  • Explanation: argumentList has been deprecated. The Swift macro template should use arguments instead.
  • Scope: The Swift macro template
  • Risk: Very low
  • Testing: Made the same modification in a macro package that was freshly generated from the template and verified that it builds without warnings
  • Issue: n/a
  • Reviewer: @MaxDesiatov on Use arguments instead of argumentList in the macro template #7422

@ahoppen
Use arguments instead of argumentList in the macro template
9b83de1 
`argumentList` has been deprecated. We should use `arguments` instead.
@ahoppen ahoppen added the swift 6.0 Related to Swift 6.0 release branch label Mar 25, 2024
@ahoppen
Copy link
Contributor Author

ahoppen commented Mar 25, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit 174e327 into apple:release/6.0 Mar 26, 2024
5 checks passed
@ahoppen ahoppen deleted the ahoppen/6.0/no-argumentlist branch March 26, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

@tomerd tomerd Awaiting requested review from tomerd tomerd is a code owner

Assignees
No one assigned
Labels
swift 6.0 Related to Swift 6.0 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahoppen @bnbarham