Fix some warnings with ProcessEnvironmentBlock
#7364
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation didn't account for case insensitivity on Windows. Cleaning up these warnings fixes that. This doesn't include APIs exposed by Swift Driver yet, as those are harder to adapt for `ProcessEnvironmentBlock` with significant sources compatibility breakage.
compnerd
approved these changes
Feb 23, 2024
|
|
||
| public typealias EnvironmentVariables = [String: String] | ||
| public typealias EnvironmentVariables = ProcessEnvironmentBlock |
There was a problem hiding this comment.
Do we need to worry about this accidentally causing build issues?
There was a problem hiding this comment.
I don't think we expose it anywhere outside of SwiftPM to any clients, at least not on purpose. IIUC corresponding TSC APIs were widely adopted instead. As soon as package support is merged in my other PR, I'll try using package visibility here to prevent any unintended adoption of this typealias in the future.
There was a problem hiding this comment.
Could use SPI in the meantime, would also make it easy to remember all the places we want package 😅
|
@swift-ci test |
…xd/process-environment-block # Conflicts: # Package.swift # Sources/SPMTestSupport/SwiftPMProduct.swift
…xd/process-environment-block # Conflicts: # Sources/Build/BuildOperation.swift # Sources/Commands/PackageCommands/InstalledPackages.swift # Sources/SPMTestSupport/MockManifestLoader.swift
|
@swift-ci test |
This APIs should not be marked `public` to prevent SwiftPM clients from adopting those by accident.
…-manager into maxd/process-environment-block # Conflicts: # Sources/Build/BuildOperationBuildSystemDelegateHandler.swift # Sources/LLBuildManifest/LLBuildManifest.swift # Sources/LLBuildManifest/LLBuildManifestWriter.swift # Sources/LLBuildManifest/Tools.swift
MaxDesiatov
added a commit
that referenced
this pull request
Mar 4, 2024
This fixes some warnings without more intrusive breaking changes for SwiftPM clients, as previously attempted in #7364. Also fixed some formatting inconsistencies.
MaxDesiatov
added a commit
that referenced
this pull request
Mar 5, 2024
This fixes some `ProcessEnv.vars` warnings without more intrusive breaking changes for SwiftPM clients, as previously attempted in #7364. Also fixed some formatting inconsistencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation didn't account for case insensitivity on Windows. Cleaning up these warnings fixes that.
This doesn't include APIs exposed by Swift Driver yet, as those are harder to adapt for
ProcessEnvironmentBlockwithout significant source compatibility breakage.